diff options
| author |   Sagi Grimberg <sagig@mellanox.com> | 2015-04-14 18:08:12 +0300 |
|---|---|---|
| committer |   Doug Ledford <dledford@redhat.com> | 2015-04-15 16:07:12 -0400 |
| commit | 30bf1d58ae8e87fef20248c7166777deab0d7f9c (patch) | |
| tree | ed6ae11e5eb773a26b7c964198e774a6da38cd12 /drivers/infiniband/ulp/iser/iser_verbs.c | |
| parent | IB/iser: Fix unload during ep_poll wrong dereference (diff) | |
| download | linux-dev-30bf1d58ae8e87fef20248c7166777deab0d7f9c.tar.xz linux-dev-30bf1d58ae8e87fef20248c7166777deab0d7f9c.zip | |
IB/iser: Handle fastreg/local_inv completion errors
Fast registration and local invalidate work requests can
also fail. We should call error completion handler for them.
Reported-by: Roi Dayan <roid@mellanox.com>
Signed-off-by: Sagi Grimberg <sagig@mellanox.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
Diffstat (limited to 'drivers/infiniband/ulp/iser/iser_verbs.c')
| -rw-r--r-- | drivers/infiniband/ulp/iser/iser_verbs.c | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/drivers/infiniband/ulp/iser/iser_verbs.c b/drivers/infiniband/ulp/iser/iser_verbs.c index 070c5af28a75..7ee4926925d3 100644 --- a/drivers/infiniband/ulp/iser/iser_verbs.c +++ b/drivers/infiniband/ulp/iser/iser_verbs.c @@ -1210,6 +1210,9 @@ iser_handle_comp_error(struct ib_conn *ib_conn, iscsi_conn_failure(iser_conn->iscsi_conn, ISCSI_ERR_CONN_FAILED); + if (wc->wr_id == ISER_FASTREG_LI_WRID) + return; + if (is_iser_tx_desc(iser_conn, wr_id)) { struct iser_tx_desc *desc = wr_id; @@ -1254,13 +1257,11 @@ static void iser_handle_wc(struct ib_wc *wc) else iser_dbg("flush error: wr id %llx\n", wc->wr_id); - if (wc->wr_id != ISER_FASTREG_LI_WRID && - wc->wr_id != ISER_BEACON_WRID) - iser_handle_comp_error(ib_conn, wc); - - /* complete in case all flush errors were consumed */ if (wc->wr_id == ISER_BEACON_WRID) + /* all flush errors were consumed */ complete(&ib_conn->flush_comp); + else + iser_handle_comp_error(ib_conn, wc); } } |