aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/infiniband/ulp/srp
diff options
context:
space:
mode:
authorSagi Grimberg <sagig@mellanox.com>2014-03-14 13:51:58 +0100
committerRoland Dreier <roland@purestorage.com>2014-03-24 10:05:30 -0700
commit2088ca66f5e986c06dc1deb4e2f004218b652300 (patch)
treee9c9fe63b8f926fc28f7b24e33eddfa814dc4045 /drivers/infiniband/ulp/srp
parentscsi_transport_srp: Fix two kernel-doc warnings (diff)
downloadlinux-dev-2088ca66f5e986c06dc1deb4e2f004218b652300.tar.xz
linux-dev-2088ca66f5e986c06dc1deb4e2f004218b652300.zip
IB/srp: Check ib_query_gid return value
Detected by Coverity. Signed-off-by: Sagi Grimberg <sagig@mellanox.com> Signed-off-by: Bart Van Assche <bvanassche@acm.org> Signed-off-by: Roland Dreier <roland@purestorage.com>
Diffstat (limited to 'drivers/infiniband/ulp/srp')
-rw-r--r--drivers/infiniband/ulp/srp/ib_srp.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c
index 529b6bcdca7a..890322637e2e 100644
--- a/drivers/infiniband/ulp/srp/ib_srp.c
+++ b/drivers/infiniband/ulp/srp/ib_srp.c
@@ -2649,7 +2649,9 @@ static ssize_t srp_create_target(struct device *dev,
if (ret)
goto err_free_mem;
- ib_query_gid(ibdev, host->port, 0, &target->path.sgid);
+ ret = ib_query_gid(ibdev, host->port, 0, &target->path.sgid);
+ if (ret)
+ goto err_free_mem;
shost_printk(KERN_DEBUG, target->scsi_host, PFX
"new target: id_ext %016llx ioc_guid %016llx pkey %04x "