diff options
| author |   Ariel Nahum <arieln@mellanox.com> | 2014-10-01 14:02:06 +0300 |
|---|---|---|
| committer |   Roland Dreier <roland@purestorage.com> | 2014-10-09 00:06:06 -0700 |
| commit | aea8f4df6da46add468c44875348e1045bffeeb7 (patch) | |
| tree | 89f0812fa9da56f2e5f2fcd5d28624e68c47843c /drivers/infiniband | |
| parent | IB/iser: Signal iSCSI layer that transport is broken in error completions (diff) | |
| download | linux-dev-aea8f4df6da46add468c44875348e1045bffeeb7.tar.xz linux-dev-aea8f4df6da46add468c44875348e1045bffeeb7.zip | |
IB/iser: Use iser_warn instead of BUG_ON in iser_conn_release
In case iscsid was violently killed (SIGKILL) during its error
recovery stage, we may never get a connection teardown sequence for
some of the old connections. No harm done, but when we try to unload
the module we will need to cleanup all these connections. So we
actually may end-up here - so it's not a BUG_ON(), just give a relaxed
warning that this happened and continue with normal unload. BUG_ON()
will cause segfault on module_exit and we don't want that.
Signed-off-by: Ariel Nahum <arieln@mellanox.com>
Signed-off-by: Roi Dayan <roid@mellanox.com>
Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>
Diffstat (limited to 'drivers/infiniband')
| -rw-r--r-- | drivers/infiniband/ulp/iser/iser_verbs.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/infiniband/ulp/iser/iser_verbs.c b/drivers/infiniband/ulp/iser/iser_verbs.c index 35f53a3fdf21..57b20c691367 100644 --- a/drivers/infiniband/ulp/iser/iser_verbs.c +++ b/drivers/infiniband/ulp/iser/iser_verbs.c @@ -627,7 +627,9 @@ void iser_conn_release(struct iser_conn *iser_conn) mutex_unlock(&ig.connlist_mutex); mutex_lock(&iser_conn->state_mutex); - BUG_ON(iser_conn->state != ISER_CONN_DOWN); + if (iser_conn->state != ISER_CONN_DOWN) + iser_warn("iser conn %p state %d, expected state down.\n", + iser_conn, iser_conn->state); /* * In case we never got to bind stage, we still need to * release IB resources (which is safe to call more than once). |