diff options
| author |   Leon Romanovsky <leonro@mellanox.com> | 2018-02-21 18:12:38 +0200 |
|---|---|---|
| committer |   Doug Ledford <dledford@redhat.com> | 2018-02-22 22:29:50 -0500 |
| commit | eb455e329bf65c75372da65a6a268c519f489183 (patch) | |
| tree | 97f468c718de2fd5adb92acc7712c61fb71a14b4 /drivers/infiniband | |
| parent | RDMA/uverbs: Refactor command header processing (diff) | |
| download | linux-dev-eb455e329bf65c75372da65a6a268c519f489183.tar.xz linux-dev-eb455e329bf65c75372da65a6a268c519f489183.zip | |
RDMA/uverbs: Properly check command supported mask
The check based on index is not sufficient because
IB_USER_VERBS_EX_CMD_CREATE_CQ = IB_USER_VERBS_CMD_CREATE_CQ
and IB_USER_VERBS_CMD_CREATE_CQ <= IB_USER_VERBS_CMD_OPEN_QP,
so if we execute IB_USER_VERBS_EX_CMD_CREATE_CQ this code checks
ib_dev->uverbs_cmd_mask not ib_dev->uverbs_ex_cmd_mask.
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
Diffstat (limited to 'drivers/infiniband')
| -rw-r--r-- | drivers/infiniband/core/uverbs_main.c | 18 |
1 files changed, 6 insertions, 12 deletions
diff --git a/drivers/infiniband/core/uverbs_main.c b/drivers/infiniband/core/uverbs_main.c index 906fcceb9ea4..1f2fd839953f 100644 --- a/drivers/infiniband/core/uverbs_main.c +++ b/drivers/infiniband/core/uverbs_main.c @@ -635,19 +635,13 @@ err_put_refs: return filp; } -static bool verify_command_mask(struct ib_device *ib_dev, __u32 command) +static bool verify_command_mask(struct ib_device *ib_dev, + __u32 command, bool extended) { - u64 mask; + if (!extended) + return ib_dev->uverbs_cmd_mask & BIT_ULL(command); - if (command <= IB_USER_VERBS_CMD_OPEN_QP) - mask = ib_dev->uverbs_cmd_mask; - else - mask = ib_dev->uverbs_ex_cmd_mask; - - if (mask & ((u64)1 << command)) - return true; - - return false; + return ib_dev->uverbs_ex_cmd_mask & BIT_ULL(command); } static bool verify_command_idx(u32 command, bool extended) @@ -722,7 +716,7 @@ static ssize_t ib_uverbs_write(struct file *filp, const char __user *buf, goto out; } - if (!verify_command_mask(ib_dev, command)) { + if (!verify_command_mask(ib_dev, command, extended)) { ret = -EOPNOTSUPP; goto out; } |