path: root/drivers/input/mouse/synaptics.c
diff options
authorBenjamin Tissoires <benjamin.tissoires@redhat.com>2017-05-26 16:51:19 -0700
committerDmitry Torokhov <dmitry.torokhov@gmail.com>2017-05-29 20:00:26 -0700
commit2fef826e45c6a1e63f55ab72546f7d795300d9a8 (patch)
tree6c08202b85340c04ee830752ba7fb352dcb4afcc /drivers/input/mouse/synaptics.c
parentInput: synaptics - warn the users when there is a better mode (diff)
Input: synaptics - tell users to report when they should be using rmi-smbus
Users should really consider switching to rmi-smbus instead of plain PS/2. Notify them that they should report a missing pnpID in the file. Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Diffstat (limited to 'drivers/input/mouse/synaptics.c')
1 files changed, 9 insertions, 1 deletions
diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
index 604aa3aa7284..16c30460ef04 100644
--- a/drivers/input/mouse/synaptics.c
+++ b/drivers/input/mouse/synaptics.c
@@ -1739,8 +1739,16 @@ static int synaptics_setup_intertouch(struct psmouse *psmouse,
if (synaptics_intertouch == SYNAPTICS_INTERTOUCH_NOT_SET) {
if (!psmouse_matches_pnp_id(psmouse, topbuttonpad_pnp_ids) &&
- !psmouse_matches_pnp_id(psmouse, smbus_pnp_ids))
+ !psmouse_matches_pnp_id(psmouse, smbus_pnp_ids)) {
+ if (!psmouse_matches_pnp_id(psmouse, forcepad_pnp_ids))
+ psmouse_info(psmouse,
+ "Your touchpad (%s) says it can support a different bus. "
+ "If i2c-hid and hid-rmi are not used, you might want to try setting psmouse.synaptics_intertouch to 1 and report this to linux-input@vger.kernel.org.\n",
+ psmouse->ps2dev.serio->firmware_id);
return -ENXIO;
+ }
psmouse_info(psmouse, "Trying to set up SMBus access\n");