diff options
| author |   Al Viro <viro@ZenIV.linux.org.uk> | 2017-02-19 07:15:27 +0000 |
|---|---|---|
| committer |   Linus Torvalds <torvalds@linux-foundation.org> | 2017-02-19 09:54:31 -0800 |
| commit | 137d01df511b3afe1f05499aea05f3bafc0fb221 (patch) | |
| tree | afb1bebd5515d5a1642bb9afb6adcd23d0fd6e6d /drivers/input/sparse-keymap.c | |
| parent | scsi: don't BUG_ON() empty DMA transfers (diff) | |
| download | linux-dev-137d01df511b3afe1f05499aea05f3bafc0fb221.tar.xz linux-dev-137d01df511b3afe1f05499aea05f3bafc0fb221.zip | |
Fix missing sanity check in /dev/sg
What happens is that a write to /dev/sg is given a request with non-zero
->iovec_count combined with zero ->dxfer_len. Or with ->dxferp pointing
to an array full of empty iovecs.
Having write permission to /dev/sg shouldn't be equivalent to the
ability to trigger BUG_ON() while holding spinlocks...
Found by Dmitry Vyukov and syzkaller.
[ The BUG_ON() got changed to a WARN_ON_ONCE(), but this fixes the
underlying issue. - Linus ]
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Reported-by: Dmitry Vyukov <dvyukov@google.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Cc: stable@vger.kernel.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/input/sparse-keymap.c')
0 files changed, 0 insertions, 0 deletions