diff options
| author |   Krzysztof Kozlowski <krzk@kernel.org> | 2020-09-15 17:52:15 -0700 |
|---|---|---|
| committer |   Dmitry Torokhov <dmitry.torokhov@gmail.com> | 2020-09-16 10:42:13 -0700 |
| commit | 4738dd1992fa13acfbbd71800c71c612f466fa44 (patch) | |
| tree | 2f8ede97f4ba90679c47308b7fb0c938a26d5b57 /drivers/input | |
| parent | Input: ep93xx_keypad - fix handling of platform_get_irq() error (diff) | |
| download | linux-dev-4738dd1992fa13acfbbd71800c71c612f466fa44.tar.xz linux-dev-4738dd1992fa13acfbbd71800c71c612f466fa44.zip | |
Input: omap4-keypad - fix handling of platform_get_irq() error
platform_get_irq() returns -ERRNO on error. In such case comparison
to 0 would pass the check.
Fixes: f3a1ba60dbdb ("Input: omap4-keypad - use platform device helpers")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Link: https://lore.kernel.org/r/20200828145744.3636-2-krzk@kernel.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Diffstat (limited to 'drivers/input')
| -rw-r--r-- | drivers/input/keyboard/omap4-keypad.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/input/keyboard/omap4-keypad.c b/drivers/input/keyboard/omap4-keypad.c index 94c94d7f5155..d6c924032aaa 100644 --- a/drivers/input/keyboard/omap4-keypad.c +++ b/drivers/input/keyboard/omap4-keypad.c @@ -240,10 +240,8 @@ static int omap4_keypad_probe(struct platform_device *pdev) } irq = platform_get_irq(pdev, 0); - if (!irq) { - dev_err(&pdev->dev, "no keyboard irq assigned\n"); - return -EINVAL; - } + if (irq < 0) + return irq; keypad_data = kzalloc(sizeof(struct omap4_keypad), GFP_KERNEL); if (!keypad_data) { |