aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/input
diff options
context:
space:
mode:
authorMatthias Schiffer <matthias.schiffer@ew.tq-group.com>2022-06-08 14:48:04 +0200
committerDmitry Torokhov <dmitry.torokhov@gmail.com>2022-09-23 13:00:13 -0700
commitd316e709cd7e3a84fa6a9b93d0c25754c0cb707e (patch)
tree719d783f08e1c820e26f65ba5b5be80a0e87f23e /drivers/input
parentInput: synaptics-rmi4 - rewrite partition table unconditionally (diff)
downloadlinux-dev-d316e709cd7e3a84fa6a9b93d0c25754c0cb707e.tar.xz
linux-dev-d316e709cd7e3a84fa6a9b93d0c25754c0cb707e.zip
Input: synaptics-rmi4 - reset after writing partition table
When recovering from a bad partition table (for example after an interrupted update), a reset is necessary for the new partition table to become effective. Without this reset, writing the core code partition will fail with status 0x03 (Invalid Command). Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com> Reviewed-by: Lyude Paul <lyude@redhat.com> Link: https://lore.kernel.org/r/20220608124808.51402-6-matthias.schiffer@ew.tq-group.com Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Diffstat (limited to 'drivers/input')
-rw-r--r--drivers/input/rmi4/rmi_f34v7.c8
1 files changed, 8 insertions, 0 deletions
diff --git a/drivers/input/rmi4/rmi_f34v7.c b/drivers/input/rmi4/rmi_f34v7.c
index 19b94b1c1a33..9b78f98bb21c 100644
--- a/drivers/input/rmi4/rmi_f34v7.c
+++ b/drivers/input/rmi4/rmi_f34v7.c
@@ -1146,6 +1146,14 @@ int rmi_f34v7_do_reflash(struct f34_data *f34, const struct firmware *fw)
goto fail;
dev_info(&f34->fn->dev, "%s: Partition table programmed\n", __func__);
+ /*
+ * Reset to reload partition table - as the previous firmware has been
+ * erased, we remain in bootloader mode.
+ */
+ ret = rmi_scan_pdt(f34->fn->rmi_dev, NULL, rmi_initial_reset);
+ if (ret < 0)
+ dev_warn(&f34->fn->dev, "RMI reset failed!\n");
+
dev_info(&f34->fn->dev, "Writing firmware (%d bytes)...\n",
f34->v7.img.ui_firmware.size);