diff options
| author |   John Garry <john.garry@huawei.com> | 2022-09-07 21:34:41 +0800 |
|---|---|---|
| committer |   Joerg Roedel <jroedel@suse.de> | 2022-09-09 09:27:03 +0200 |
| commit | 189cb8fec14acf4dee59eb2011519e86d389cd3e (patch) | |
| tree | 42fd93c1b6d29310be0630665e9928e77e806bf3 /drivers/iommu | |
| parent | iova: Remove magazine BUG_ON() checks (diff) | |
| download | linux-dev-189cb8fec14acf4dee59eb2011519e86d389cd3e.tar.xz linux-dev-189cb8fec14acf4dee59eb2011519e86d389cd3e.zip | |
iova: Remove iovad->rcaches check in iova_rcache_get()
The iovad->rcaches check in iova_rcache_get() is pretty much useless
without the same check in iova_rcache_insert().
Instead of adding this symmetric check to fastpath iova_rcache_insert(),
drop the check in iova_rcache_get() in favour of making the IOVA domain
rcache init more robust to failure in future.
Signed-off-by: John Garry <john.garry@huawei.com>
Reviewed-by: Robin Murphy <robin.murphy@arm.com>
Link: https://lore.kernel.org/r/1662557681-145906-4-git-send-email-john.garry@huawei.com
Signed-off-by: Joerg Roedel <jroedel@suse.de>
Diffstat (limited to 'drivers/iommu')
| -rw-r--r-- | drivers/iommu/iova.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/iommu/iova.c b/drivers/iommu/iova.c index 8aece052ce72..a44ad92fc5eb 100644 --- a/drivers/iommu/iova.c +++ b/drivers/iommu/iova.c @@ -875,7 +875,7 @@ static unsigned long iova_rcache_get(struct iova_domain *iovad, { unsigned int log_size = order_base_2(size); - if (log_size >= IOVA_RANGE_CACHE_MAX_SIZE || !iovad->rcaches) + if (log_size >= IOVA_RANGE_CACHE_MAX_SIZE) return 0; return __iova_rcache_get(&iovad->rcaches[log_size], limit_pfn - size); |