diff options
| author |   Arnd Bergmann <arnd@arndb.de> | 2019-06-17 15:30:54 +0200 |
|---|---|---|
| committer |   Joerg Roedel <jroedel@suse.de> | 2019-06-18 17:24:42 +0200 |
| commit | 29fcea8ce7f3c16ebd267f8cb2f4a07887530aa9 (patch) | |
| tree | 87843c08754266b1e890b157ad2b21ff8d44ba18 /drivers/iommu | |
| parent | iommu: Add padding to struct iommu_fault (diff) | |
| download | linux-dev-29fcea8ce7f3c16ebd267f8cb2f4a07887530aa9.tar.xz linux-dev-29fcea8ce7f3c16ebd267f8cb2f4a07887530aa9.zip | |
iommu: Fix integer truncation
On 32-bit architectures, phys_addr_t may be different from dma_add_t,
both smaller and bigger. This can lead to an overflow during an assignment
that clang warns about:
drivers/iommu/dma-iommu.c:230:10: error: implicit conversion from 'dma_addr_t' (aka 'unsigned long long') to
'phys_addr_t' (aka 'unsigned int') changes value from 18446744073709551615 to 4294967295 [-Werror,-Wconstant-conversion]
Use phys_addr_t here because that is the type that the variable was
declared as.
Fixes: aadad097cd46 ("iommu/dma: Reserve IOVA for PCIe inaccessible DMA address")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Joerg Roedel <jroedel@suse.de>
Diffstat (limited to 'drivers/iommu')
| -rw-r--r-- | drivers/iommu/dma-iommu.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/iommu/dma-iommu.c b/drivers/iommu/dma-iommu.c index 129c4badf9ae..749e3251ee85 100644 --- a/drivers/iommu/dma-iommu.c +++ b/drivers/iommu/dma-iommu.c @@ -240,8 +240,8 @@ resv_iova: start = window->res->end - window->offset + 1; /* If window is last entry */ if (window->node.next == &bridge->dma_ranges && - end != ~(dma_addr_t)0) { - end = ~(dma_addr_t)0; + end != ~(phys_addr_t)0) { + end = ~(phys_addr_t)0; goto resv_iova; } } |