diff options
| author |   Colin Ian King <colin.king@canonical.com> | 2021-02-04 15:00:01 +0000 |
|---|---|---|
| committer |   Joerg Roedel <jroedel@suse.de> | 2021-02-05 09:49:47 +0100 |
| commit | 7a5661739d4bf23cd356fb13bb1e0790e09df3c5 (patch) | |
| tree | ed2b5f8ad31bd3aec73161bd8a5e8a25f4c425ad /drivers/iommu | |
| parent | iommu: Properly pass gfp_t in _iommu_map() to avoid atomic sleeping (diff) | |
| download | linux-dev-7a5661739d4bf23cd356fb13bb1e0790e09df3c5.tar.xz linux-dev-7a5661739d4bf23cd356fb13bb1e0790e09df3c5.zip | |
iommu/mediatek: Fix unsigned domid comparison with less than zero
Currently the check for domid < 0 is always false because domid
is unsigned. Fix this by casting domid to an int before making
the comparison.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Will Deacon <will@kernel.org>
Link: https://lore.kernel.org/r/20210204150001.102672-1-colin.king@canonical.com
Addresses-Coverity: ("Unsigned comparison against 0")
Signed-off-by: Joerg Roedel <jroedel@suse.de>
Diffstat (limited to 'drivers/iommu')
| -rw-r--r-- | drivers/iommu/mtk_iommu.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c index 0ad14a7604b1..1f262621ef19 100644 --- a/drivers/iommu/mtk_iommu.c +++ b/drivers/iommu/mtk_iommu.c @@ -645,7 +645,7 @@ static void mtk_iommu_get_resv_regions(struct device *dev, struct iommu_resv_region *region; int prot = IOMMU_WRITE | IOMMU_READ; - if (domid < 0) + if ((int)domid < 0) return; curdom = data->plat_data->iova_region + domid; for (i = 0; i < data->plat_data->iova_region_nr; i++) { |