diff options
| author |   Jordan Crouse <jcrouse@codeaurora.org> | 2017-12-20 09:48:36 -0700 |
|---|---|---|
| committer |   Alex Williamson <alex.williamson@redhat.com> | 2017-12-20 09:48:36 -0700 |
| commit | 9ae9df035c274c89b7fe3dbc74cbe2fa63386668 (patch) | |
| tree | 605af1864dcdf4a50d3f0902c82365a744d27f11 /drivers/iommu | |
| parent | Linux 4.15-rc4 (diff) | |
| download | linux-dev-9ae9df035c274c89b7fe3dbc74cbe2fa63386668.tar.xz linux-dev-9ae9df035c274c89b7fe3dbc74cbe2fa63386668.zip | |
iommu: Check the result of iommu_group_get() for NULL
The result of iommu_group_get() was being blindly used in both
attach and detach which results in a dereference when trying
to work with an unknown device.
Signed-off-by: Jordan Crouse <jcrouse@codeaurora.org>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
Diffstat (limited to 'drivers/iommu')
| -rw-r--r-- | drivers/iommu/iommu.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c index 3de5c0bcb5cc..69fef991c651 100644 --- a/drivers/iommu/iommu.c +++ b/drivers/iommu/iommu.c @@ -1303,6 +1303,9 @@ int iommu_attach_device(struct iommu_domain *domain, struct device *dev) int ret; group = iommu_group_get(dev); + if (!group) + return -ENODEV; + /* * Lock the group to make sure the device-count doesn't * change while we are attaching @@ -1341,6 +1344,8 @@ void iommu_detach_device(struct iommu_domain *domain, struct device *dev) struct iommu_group *group; group = iommu_group_get(dev); + if (!group) + return; mutex_lock(&group->mutex); if (iommu_group_device_count(group) != 1) { |