aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/iommu
diff options
context:
space:
mode:
authorJoerg Roedel <jroedel@suse.de>2015-10-20 17:33:34 +0200
committerJoerg Roedel <jroedel@suse.de>2015-10-21 11:29:26 +0200
commitf34c73f55a06ac443c492fc11b85f7a44dfdc112 (patch)
treeebe71ad583fb74d04d65e9c85af2a6d2d724cb5c /drivers/iommu
parentiommu/amd: Drop null test before destroy functions (diff)
downloadlinux-dev-f34c73f55a06ac443c492fc11b85f7a44dfdc112.tar.xz
linux-dev-f34c73f55a06ac443c492fc11b85f7a44dfdc112.zip
iommu/amd: Do not BUG_ON in __detach_device()
The condition in the BUG_ON is an indicator of a BUG, but no reason to kill the code path. Turn it into a WARN_ON and bail out if it is hit. Signed-off-by: Joerg Roedel <jroedel@suse.de>
Diffstat (limited to 'drivers/iommu')
-rw-r--r--drivers/iommu/amd_iommu.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
index f82060e778a2..6070b1504497 100644
--- a/drivers/iommu/amd_iommu.c
+++ b/drivers/iommu/amd_iommu.c
@@ -2204,7 +2204,8 @@ static void __detach_device(struct iommu_dev_data *dev_data)
struct protection_domain *domain;
unsigned long flags;
- BUG_ON(!dev_data->domain);
+ if (WARN_ON(!dev_data->domain))
+ return;
domain = dev_data->domain;