diff options
| author |   Florian Fainelli <f.fainelli@gmail.com> | 2022-03-08 12:11:16 -0800 |
|---|---|---|
| committer |   Marc Zyngier <maz@kernel.org> | 2022-05-04 16:52:28 +0100 |
| commit | 4c5b2be1d071af26749790429726712e4d9105fb (patch) | |
| tree | 67aa698cc31970f6b8e331a12558200b1a0be83d /drivers/irqchip/irq-gic.c | |
| parent | irqchip/csky: Return true/false (not 1/0) from bool functions (diff) | |
| download | linux-dev-4c5b2be1d071af26749790429726712e4d9105fb.tar.xz linux-dev-4c5b2be1d071af26749790429726712e4d9105fb.zip | |
irqchip/gic: Improved warning about incorrect type
Issue the warning for interrupt lines that have an incorrect interrupt
type and also print the hardware interrupt number to facilitate the
resolution of such problems.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20220308201117.3870678-1-f.fainelli@gmail.com
Diffstat (limited to 'drivers/irqchip/irq-gic.c')
| -rw-r--r-- | drivers/irqchip/irq-gic.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c index 09c710ecc387..820404cb56bc 100644 --- a/drivers/irqchip/irq-gic.c +++ b/drivers/irqchip/irq-gic.c @@ -1115,7 +1115,8 @@ static int gic_irq_domain_translate(struct irq_domain *d, *type = fwspec->param[2] & IRQ_TYPE_SENSE_MASK; /* Make it clear that broken DTs are... broken */ - WARN_ON(*type == IRQ_TYPE_NONE); + WARN(*type == IRQ_TYPE_NONE, + "HW irq %ld has invalid type\n", *hwirq); return 0; } @@ -1132,7 +1133,8 @@ static int gic_irq_domain_translate(struct irq_domain *d, *hwirq = fwspec->param[0]; *type = fwspec->param[1]; - WARN_ON(*type == IRQ_TYPE_NONE); + WARN(*type == IRQ_TYPE_NONE, + "HW irq %ld has invalid type\n", *hwirq); return 0; } |