diff options
| author |   Kaige Fu <kaige.fu@linux.alibaba.com> | 2021-09-15 10:20:55 +0800 |
|---|---|---|
| committer |   Marc Zyngier <maz@kernel.org> | 2021-09-22 14:37:04 +0100 |
| commit | 280bef512933b2dda01d681d8cbe499b98fc5bdd (patch) | |
| tree | f9e620c59ee81b6494132271fc2700efed9d0dc4 /drivers/irqchip | |
| parent | irqchip/goldfish-pic: Select GENERIC_IRQ_CHIP to fix build (diff) | |
| download | linux-dev-280bef512933b2dda01d681d8cbe499b98fc5bdd.tar.xz linux-dev-280bef512933b2dda01d681d8cbe499b98fc5bdd.zip | |
irqchip/gic-v3-its: Fix potential VPE leak on error
In its_vpe_irq_domain_alloc, when its_vpe_init() returns an error,
there is an off-by-one in the number of VPEs to be freed.
Fix it by simply passing the number of VPEs allocated, which is the
index of the loop iterating over the VPEs.
Fixes: 7d75bbb4bc1a ("irqchip/gic-v3-its: Add VPE irq domain allocation/teardown")
Signed-off-by: Kaige Fu <kaige.fu@linux.alibaba.com>
[maz: fixed commit message]
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/d9e36dee512e63670287ed9eff884a5d8d6d27f2.1631672311.git.kaige.fu@linux.alibaba.com
Diffstat (limited to 'drivers/irqchip')
| -rw-r--r-- | drivers/irqchip/irq-gic-v3-its.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c index 7f40dca8cda5..eb0882d15366 100644 --- a/drivers/irqchip/irq-gic-v3-its.c +++ b/drivers/irqchip/irq-gic-v3-its.c @@ -4501,7 +4501,7 @@ static int its_vpe_irq_domain_alloc(struct irq_domain *domain, unsigned int virq if (err) { if (i > 0) - its_vpe_irq_domain_free(domain, virq, i - 1); + its_vpe_irq_domain_free(domain, virq, i); its_lpi_free(bitmap, base, nr_ids); its_free_prop_table(vprop_page); |