diff options
| author |   Marek Behún <marek.behun@nic.cz> | 2020-09-18 00:32:57 +0200 |
|---|---|---|
| committer |   Pavel Machek <pavel@ucw.cz> | 2020-09-26 21:56:39 +0200 |
| commit | 2c67756254349d2b4a1af92c846e32f7e15fae89 (patch) | |
| tree | 6c2344683d2a4d93ed9c9d8fee7708858a2a6f4b /drivers/leds | |
| parent | leds: various: use only available OF children (diff) | |
| download | linux-dev-2c67756254349d2b4a1af92c846e32f7e15fae89.tar.xz linux-dev-2c67756254349d2b4a1af92c846e32f7e15fae89.zip | |
leds: various: fix OF node leaks
Fix OF node leaks by calling of_node_put in
for_each_available_child_of_node when the cycle breaks or returns.
Signed-off-by: Marek Behún <marek.behun@nic.cz>
Cc: Nikita Travkin <nikitos.tr@gmail.com>
Cc: Milo Kim <milo.kim@ti.com>
Cc: Dan Murphy <dmurphy@ti.com>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
Not-for-stable: untested, theoretical, insignificant leaks
Diffstat (limited to 'drivers/leds')
| -rw-r--r-- | drivers/leds/leds-aw2013.c | 4 | ||||
| -rw-r--r-- | drivers/leds/leds-lp55xx-common.c | 8 | ||||
| -rw-r--r-- | drivers/leds/leds-turris-omnia.c | 4 |
3 files changed, 12 insertions, 4 deletions
diff --git a/drivers/leds/leds-aw2013.c b/drivers/leds/leds-aw2013.c index 9df7de042bca..927c5ba32592 100644 --- a/drivers/leds/leds-aw2013.c +++ b/drivers/leds/leds-aw2013.c @@ -305,8 +305,10 @@ static int aw2013_probe_dt(struct aw2013 *chip) ret = devm_led_classdev_register_ext(&chip->client->dev, &led->cdev, &init_data); - if (ret < 0) + if (ret < 0) { + of_node_put(child); return ret; + } i++; } diff --git a/drivers/leds/leds-lp55xx-common.c b/drivers/leds/leds-lp55xx-common.c index 50f7f5b87463..81de1346bf5d 100644 --- a/drivers/leds/leds-lp55xx-common.c +++ b/drivers/leds/leds-lp55xx-common.c @@ -614,8 +614,10 @@ static int lp55xx_parse_multi_led(struct device_node *np, for_each_available_child_of_node(np, child) { ret = lp55xx_parse_multi_led_child(child, cfg, child_number, num_colors); - if (ret) + if (ret) { + of_node_put(child); return ret; + } num_colors++; } @@ -681,8 +683,10 @@ struct lp55xx_platform_data *lp55xx_of_populate_pdata(struct device *dev, for_each_available_child_of_node(np, child) { ret = lp55xx_parse_logical_led(child, cfg, i); - if (ret) + if (ret) { + of_node_put(child); return ERR_PTR(-EINVAL); + } i++; } diff --git a/drivers/leds/leds-turris-omnia.c b/drivers/leds/leds-turris-omnia.c index ea7da8517220..117976cf75c8 100644 --- a/drivers/leds/leds-turris-omnia.c +++ b/drivers/leds/leds-turris-omnia.c @@ -236,8 +236,10 @@ static int omnia_leds_probe(struct i2c_client *client, led = &leds->leds[0]; for_each_available_child_of_node(np, child) { ret = omnia_led_register(client, led, child); - if (ret < 0) + if (ret < 0) { + of_node_put(child); return ret; + } led += ret; } |