diff options
| author |   Andy Shevchenko <andy.shevchenko@gmail.com> | 2021-05-10 12:50:33 +0300 |
|---|---|---|
| committer |   Pavel Machek <pavel@ucw.cz> | 2021-05-28 12:00:14 +0200 |
| commit | 3c5f655c44bb65cb7e3c219d08c130ce5fa45d7f (patch) | |
| tree | c54fa42bd44d93e35046a0167c3bca38bdcf07b0 /drivers/leds | |
| parent | leds: lm3532: Make error handling more robust (diff) | |
| download | linux-dev-3c5f655c44bb65cb7e3c219d08c130ce5fa45d7f.tar.xz linux-dev-3c5f655c44bb65cb7e3c219d08c130ce5fa45d7f.zip | |
leds: lm36274: Put fwnode in error case during ->probe()
device_get_next_child_node() bumps a reference counting of a returned variable.
We have to balance it whenever we return to the caller.
In the older code the same is implied with device_for_each_child_node().
Fixes: 11e1bbc116a7 ("leds: lm36274: Introduce the TI LM36274 LED driver")
Fixes: a448fcf19c9c ("leds: lm36274: don't iterate through children since there is only one")
Cc: Dan Murphy <dmurphy@ti.com>
Cc: Marek Behún <marek.behun@nic.cz>
Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
Diffstat (limited to 'drivers/leds')
| -rw-r--r-- | drivers/leds/leds-lm36274.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/leds/leds-lm36274.c b/drivers/leds/leds-lm36274.c index aadb03468a40..a23a9424c2f3 100644 --- a/drivers/leds/leds-lm36274.c +++ b/drivers/leds/leds-lm36274.c @@ -127,6 +127,7 @@ static int lm36274_probe(struct platform_device *pdev) ret = lm36274_init(chip); if (ret) { + fwnode_handle_put(init_data.fwnode); dev_err(chip->dev, "Failed to init the device\n"); return ret; } |