diff options
| author |   Krzysztof Kozlowski <krzk@kernel.org> | 2020-08-26 16:50:10 +0200 |
|---|---|---|
| committer |   Pavel Machek <pavel@ucw.cz> | 2020-09-09 11:20:09 +0200 |
| commit | 47eaa8ba12cc77895e2591ec57091bed7b3d9817 (patch) | |
| tree | e708bb7403a027ad44123dcd5fdc590d0f2fbefc /drivers/leds | |
| parent | DT: leds: Add an optional property named 'shutdown-gpios' (diff) | |
| download | linux-dev-47eaa8ba12cc77895e2591ec57091bed7b3d9817.tar.xz linux-dev-47eaa8ba12cc77895e2591ec57091bed7b3d9817.zip | |
leds: lm3692x: Simplify with dev_err_probe()
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and also it prints the error value.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
Diffstat (limited to 'drivers/leds')
| -rw-r--r-- | drivers/leds/leds-lm3692x.c | 11 |
1 files changed, 4 insertions, 7 deletions
diff --git a/drivers/leds/leds-lm3692x.c b/drivers/leds/leds-lm3692x.c index e1e2d2b64a56..1d7ea1b76a12 100644 --- a/drivers/leds/leds-lm3692x.c +++ b/drivers/leds/leds-lm3692x.c @@ -394,13 +394,10 @@ static int lm3692x_probe_dt(struct lm3692x_led *led) led->regulator = devm_regulator_get_optional(&led->client->dev, "vled"); if (IS_ERR(led->regulator)) { ret = PTR_ERR(led->regulator); - if (ret != -ENODEV) { - if (ret != -EPROBE_DEFER) - dev_err(&led->client->dev, - "Failed to get vled regulator: %d\n", - ret); - return ret; - } + if (ret != -ENODEV) + return dev_err_probe(&led->client->dev, ret, + "Failed to get vled regulator\n"); + led->regulator = NULL; } |