aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/lightnvm/pblk-rb.c
diff options
context:
space:
mode:
authorIgor Konopko <igor.j.konopko@intel.com>2019-05-04 20:37:59 +0200
committerJens Axboe <axboe@kernel.dk>2019-05-06 10:19:18 -0600
commit486b5aac85f6ec0b2df3e82a6a629d5eb7804db5 (patch)
tree352133997591e3a83c29f8f6ec5430ce6671e6c2 /drivers/lightnvm/pblk-rb.c
parentlightnvm: prevent race condition on pblk remove (diff)
downloadlinux-dev-486b5aac85f6ec0b2df3e82a6a629d5eb7804db5.tar.xz
linux-dev-486b5aac85f6ec0b2df3e82a6a629d5eb7804db5.zip
lightnvm: pblk: fix lock order in pblk_rb_tear_down_check
In pblk_rb_tear_down_check() the spinlock functions are not called in proper order. Fixes: a4bd217 ("lightnvm: physical block device (pblk) target") Signed-off-by: Igor Konopko <igor.j.konopko@intel.com> Reviewed-by: Javier González <javier@javigon.com> Reviewed-by: Hans Holmberg <hans.holmberg@cnexlabs.com> Signed-off-by: Matias Bjørling <mb@lightnvm.io> Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'drivers/lightnvm/pblk-rb.c')
-rw-r--r--drivers/lightnvm/pblk-rb.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/lightnvm/pblk-rb.c b/drivers/lightnvm/pblk-rb.c
index 03c241b340ea..35550148b5e8 100644
--- a/drivers/lightnvm/pblk-rb.c
+++ b/drivers/lightnvm/pblk-rb.c
@@ -799,8 +799,8 @@ int pblk_rb_tear_down_check(struct pblk_rb *rb)
}
out:
- spin_unlock(&rb->w_lock);
spin_unlock_irq(&rb->s_lock);
+ spin_unlock(&rb->w_lock);
return ret;
}