diff options
| author |   Colin Ian King <colin.king@canonical.com> | 2018-06-05 16:14:56 +0100 |
|---|---|---|
| committer |   Jens Axboe <axboe@kernel.dk> | 2018-06-05 09:20:27 -0600 |
| commit | 0ec6937e8e1251db1f2f54259ba5c16dbdb2b943 (patch) | |
| tree | a10d6ff943013ca12d4fcbea863a12a276eadb53 /drivers/lightnvm | |
| parent | lightnvm: pblk: make symbol write_buffer_size static (diff) | |
| download | linux-dev-0ec6937e8e1251db1f2f54259ba5c16dbdb2b943.tar.xz linux-dev-0ec6937e8e1251db1f2f54259ba5c16dbdb2b943.zip | |
lightnvm: pblk: fix resource leak of invalid_bitmap
Currently the error exit path when the emeta could not be
interpreted is via fail_free_ws and this fails to free
invalid_bitmap. Fix this by adding another exit label and
exiting via this to kfree invalid_bitmap.
Detected by CoverityScan, CID#1469659 ("Resource leak")
Fixes: 48b8d20895f8 ("lightnvm: pblk: garbage collect lines with failed writes")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'drivers/lightnvm')
| -rw-r--r-- | drivers/lightnvm/pblk-gc.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/lightnvm/pblk-gc.c b/drivers/lightnvm/pblk-gc.c index df88f1bdd921..6a4883e40cc0 100644 --- a/drivers/lightnvm/pblk-gc.c +++ b/drivers/lightnvm/pblk-gc.c @@ -203,7 +203,7 @@ static void pblk_gc_line_prepare_ws(struct work_struct *work) if (!lba_list) { pr_err("pblk: could not interpret emeta (line %d)\n", line->id); - goto fail_free_ws; + goto fail_free_invalid_bitmap; } } @@ -280,6 +280,7 @@ fail_free_gc_rq: kfree(gc_rq); fail_free_lba_list: pblk_mfree(lba_list, l_mg->emeta_alloc_type); +fail_free_invalid_bitmap: kfree(invalid_bitmap); fail_free_ws: kfree(line_ws); |