diff options
| author |   Pan Bian <bianpan2016@163.com> | 2021-01-20 23:22:02 -0800 |
|---|---|---|
| committer |   Jens Axboe <axboe@kernel.dk> | 2021-01-21 05:45:51 -0700 |
| commit | 97784481757fba7570121a70dd37ca74a29f50a8 (patch) | |
| tree | ccee7ca08a90a00af966d2a6a87d862b2dd32519 /drivers/lightnvm | |
| parent | Merge tag 'nvme-5.11-2020-01-21' of git://git.infradead.org/nvme into block-5.11 (diff) | |
| download | linux-dev-97784481757fba7570121a70dd37ca74a29f50a8.tar.xz linux-dev-97784481757fba7570121a70dd37ca74a29f50a8.zip | |
lightnvm: fix memory leak when submit fails
The allocated page is not released if error occurs in
nvm_submit_io_sync_raw(). __free_page() is moved ealier to avoid
possible memory leak issue.
Fixes: aff3fb18f957 ("lightnvm: move bad block and chunk state logic to core")
Signed-off-by: Pan Bian <bianpan2016@163.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'drivers/lightnvm')
| -rw-r--r-- | drivers/lightnvm/core.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c index c1bcac71008c..28ddcaa5358b 100644 --- a/drivers/lightnvm/core.c +++ b/drivers/lightnvm/core.c @@ -844,11 +844,10 @@ static int nvm_bb_chunk_sense(struct nvm_dev *dev, struct ppa_addr ppa) rqd.ppa_addr = generic_to_dev_addr(dev, ppa); ret = nvm_submit_io_sync_raw(dev, &rqd); + __free_page(page); if (ret) return ret; - __free_page(page); - return rqd.error; } |