diff options
| author |   Guoju Fang <fangguoju@gmail.com> | 2018-09-27 23:41:46 +0800 |
|---|---|---|
| committer |   Jens Axboe <axboe@kernel.dk> | 2018-09-27 09:47:01 -0600 |
| commit | 0f843e65d9eef4936929bb036c5f771fb261eea4 (patch) | |
| tree | b02f7ba31960169e8789a54b3c546d50834b0da9 /drivers/md/bcache/bcache.h | |
| parent | xen/blkfront: When purging persistent grants, keep them in the buffer (diff) | |
| download | linux-dev-0f843e65d9eef4936929bb036c5f771fb261eea4.tar.xz linux-dev-0f843e65d9eef4936929bb036c5f771fb261eea4.zip | |
bcache: add separate workqueue for journal_write to avoid deadlock
After write SSD completed, bcache schedules journal_write work to
system_wq, which is a public workqueue in system, without WQ_MEM_RECLAIM
flag. system_wq is also a bound wq, and there may be no idle kworker on
current processor. Creating a new kworker may unfortunately need to
reclaim memory first, by shrinking cache and slab used by vfs, which
depends on bcache device. That's a deadlock.
This patch create a new workqueue for journal_write with WQ_MEM_RECLAIM
flag. It's rescuer thread will work to avoid the deadlock.
Signed-off-by: Guoju Fang <fangguoju@gmail.com>
Cc: stable@vger.kernel.org
Signed-off-by: Coly Li <colyli@suse.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'drivers/md/bcache/bcache.h')
| -rw-r--r-- | drivers/md/bcache/bcache.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/md/bcache/bcache.h b/drivers/md/bcache/bcache.h index 83504dd8100a..954dad29e6e8 100644 --- a/drivers/md/bcache/bcache.h +++ b/drivers/md/bcache/bcache.h @@ -965,6 +965,7 @@ void bch_prio_write(struct cache *ca); void bch_write_bdev_super(struct cached_dev *dc, struct closure *parent); extern struct workqueue_struct *bcache_wq; +extern struct workqueue_struct *bch_journal_wq; extern struct mutex bch_register_lock; extern struct list_head bch_cache_sets; |