diff options
| author |   Kent Overstreet <koverstreet@google.com> | 2013-06-05 06:24:39 -0700 |
|---|---|---|
| committer | Kent Overstreet <koverstreet@google.com> | 2013-06-26 21:58:04 -0700 |
| commit | 72c270612bd33192fa836ad0f2939af1ca218292 (patch) | |
| tree | 344129d75f3b5c0abcf77dd4b6340783a126cde8 /drivers/md/bcache/movinggc.c | |
| parent | bcache: Track dirty data by stripe (diff) | |
| download | linux-dev-72c270612bd33192fa836ad0f2939af1ca218292.tar.xz linux-dev-72c270612bd33192fa836ad0f2939af1ca218292.zip | |
bcache: Write out full stripes
Now that we're tracking dirty data per stripe, we can add two
optimizations for raid5/6:
* If a stripe is already dirty, force writes to that stripe to
writeback mode - to help build up full stripes of dirty data
* When flushing dirty data, preferentially write out full stripes first
if there are any.
Signed-off-by: Kent Overstreet <koverstreet@google.com>
Diffstat (limited to 'drivers/md/bcache/movinggc.c')
| -rw-r--r-- | drivers/md/bcache/movinggc.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/md/bcache/movinggc.c b/drivers/md/bcache/movinggc.c index 04f6b97ffda6..a241e9fd4f7f 100644 --- a/drivers/md/bcache/movinggc.c +++ b/drivers/md/bcache/movinggc.c @@ -136,7 +136,8 @@ static void read_moving(struct closure *cl) /* XXX: if we error, background writeback could stall indefinitely */ while (!test_bit(CACHE_SET_STOPPING, &c->flags)) { - w = bch_keybuf_next_rescan(c, &c->moving_gc_keys, &MAX_KEY); + w = bch_keybuf_next_rescan(c, &c->moving_gc_keys, + &MAX_KEY, moving_pred); if (!w) break; @@ -248,5 +249,5 @@ void bch_moving_gc(struct closure *cl) void bch_moving_init_cache_set(struct cache_set *c) { - bch_keybuf_init(&c->moving_gc_keys, moving_pred); + bch_keybuf_init(&c->moving_gc_keys); } |