diff options
| author |   Mike Snitzer <snitzer@kernel.org> | 2022-08-04 15:55:57 -0400 |
|---|---|---|
| committer | Mike Snitzer <snitzer@kernel.org> | 2022-08-04 15:59:52 -0400 |
| commit | 12907efde6ad984f2d76cc1a7dbaae132384d8a5 (patch) | |
| tree | af25a5c018db23af465c2a67b6d6d8e7f54724d6 /drivers/md/dm-verity-target.c | |
| parent | dm verity: remove WQ_CPU_INTENSIVE flag since using WQ_UNBOUND (diff) | |
| download | linux-dev-12907efde6ad984f2d76cc1a7dbaae132384d8a5.tar.xz linux-dev-12907efde6ad984f2d76cc1a7dbaae132384d8a5.zip | |
dm verity: have verify_wq use WQ_HIGHPRI if "try_verify_in_tasklet"
Allow verify_wq to preempt softirq since verification in tasklet will
fall-back to using it for error handling (or if the bufio cache
doesn't have required hashes).
Suggested-by: Nathan Huckleberry <nhuck@google.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>
Diffstat (limited to 'drivers/md/dm-verity-target.c')
| -rw-r--r-- | drivers/md/dm-verity-target.c | 12 |
1 files changed, 11 insertions, 1 deletions
diff --git a/drivers/md/dm-verity-target.c b/drivers/md/dm-verity-target.c index 9b87db8ef99f..981821f18a18 100644 --- a/drivers/md/dm-verity-target.c +++ b/drivers/md/dm-verity-target.c @@ -1151,6 +1151,7 @@ static int verity_ctr(struct dm_target *ti, unsigned argc, char **argv) struct dm_verity_sig_opts verify_args = {0}; struct dm_arg_set as; unsigned int num; + unsigned int wq_flags; unsigned long long num_ll; int r; int i; @@ -1388,7 +1389,16 @@ static int verity_ctr(struct dm_target *ti, unsigned argc, char **argv) } /* WQ_UNBOUND greatly improves performance when running on ramdisk */ - v->verify_wq = alloc_workqueue("kverityd", WQ_MEM_RECLAIM | WQ_UNBOUND, num_online_cpus()); + wq_flags = WQ_MEM_RECLAIM | WQ_UNBOUND; + if (v->use_tasklet) { + /* + * Allow verify_wq to preempt softirq since verification in + * tasklet will fall-back to using it for error handling + * (or if the bufio cache doesn't have required hashes). + */ + wq_flags |= WQ_HIGHPRI; + } + v->verify_wq = alloc_workqueue("kverityd", wq_flags, num_online_cpus()); if (!v->verify_wq) { ti->error = "Cannot allocate workqueue"; r = -ENOMEM; |