diff options
| author |   Pawel Baldysiak <pawel.baldysiak@intel.com> | 2019-03-27 13:48:21 +0100 |
|---|---|---|
| committer |   Song Liu <songliubraving@fb.com> | 2019-04-16 09:31:21 -0700 |
| commit | c42d3240990814eec1e4b2b93fa0487fc4873aed (patch) | |
| tree | 01daefa659700d4d088696e3e4be9284280867a8 /drivers/md/md.c | |
| parent | block: fix use-after-free on gendisk (diff) | |
| download | linux-dev-c42d3240990814eec1e4b2b93fa0487fc4873aed.tar.xz linux-dev-c42d3240990814eec1e4b2b93fa0487fc4873aed.zip | |
md: return -ENODEV if rdev has no mddev assigned
Mdadm expects that setting drive as faulty will fail with -EBUSY only if
this operation will cause RAID to be failed. If this happens, it will
try to stop the array. Currently -EBUSY might also be returned if rdev
is in the middle of the removal process - for example there is a race
with mdmon that already requested the drive to be failed/removed.
If rdev does not contain mddev, return -ENODEV instead, so the caller
can distinguish between those two cases and behave accordingly.
Reviewed-by: NeilBrown <neilb@suse.com>
Signed-off-by: Pawel Baldysiak <pawel.baldysiak@intel.com>
Signed-off-by: Song Liu <songliubraving@fb.com>
Diffstat (limited to 'drivers/md/md.c')
| -rw-r--r-- | drivers/md/md.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/md/md.c b/drivers/md/md.c index 541015373f6a..45ffa23fa85d 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -3380,10 +3380,10 @@ rdev_attr_store(struct kobject *kobj, struct attribute *attr, return -EIO; if (!capable(CAP_SYS_ADMIN)) return -EACCES; - rv = mddev ? mddev_lock(mddev): -EBUSY; + rv = mddev ? mddev_lock(mddev) : -ENODEV; if (!rv) { if (rdev->mddev == NULL) - rv = -EBUSY; + rv = -ENODEV; else rv = entry->store(rdev, page, length); mddev_unlock(mddev); |