diff options
| author |   NeilBrown <neilb@suse.com> | 2016-11-09 10:21:33 +1100 |
|---|---|---|
| committer |   Shaohua Li <shli@fb.com> | 2016-11-09 12:53:52 -0800 |
| commit | be306c2989804ca5b90388df66fd3cf28ec74967 (patch) | |
| tree | 15989e3e90f2050e877ac5d1af6265787d741a10 /drivers/md/raid1.h | |
| parent | md/raid1: fix: IO can block resync indefinitely (diff) | |
| download | linux-dev-be306c2989804ca5b90388df66fd3cf28ec74967.tar.xz linux-dev-be306c2989804ca5b90388df66fd3cf28ec74967.zip | |
md: define mddev flags, recovery flags and r1bio state bits using enums
This is less error prone than using individual #defines.
Signed-off-by: NeilBrown <neilb@suse.com>
Signed-off-by: Shaohua Li <shli@fb.com>
Diffstat (limited to 'drivers/md/raid1.h')
| -rw-r--r-- | drivers/md/raid1.h | 18 |
1 files changed, 10 insertions, 8 deletions
diff --git a/drivers/md/raid1.h b/drivers/md/raid1.h index 61c39b390cd8..5ec19449779d 100644 --- a/drivers/md/raid1.h +++ b/drivers/md/raid1.h @@ -161,14 +161,15 @@ struct r1bio { }; /* bits for r1bio.state */ -#define R1BIO_Uptodate 0 -#define R1BIO_IsSync 1 -#define R1BIO_Degraded 2 -#define R1BIO_BehindIO 3 +enum r1bio_state { + R1BIO_Uptodate, + R1BIO_IsSync, + R1BIO_Degraded, + R1BIO_BehindIO, /* Set ReadError on bios that experience a readerror so that * raid1d knows what to do with them. */ -#define R1BIO_ReadError 4 + R1BIO_ReadError, /* For write-behind requests, we call bi_end_io when * the last non-write-behind device completes, providing * any write was successful. Otherwise we call when @@ -176,10 +177,11 @@ struct r1bio { * with failure when last write completes (and all failed). * Record that bi_end_io was called with this flag... */ -#define R1BIO_Returned 6 + R1BIO_Returned, /* If a write for this request means we can clear some * known-bad-block records, we set this flag */ -#define R1BIO_MadeGood 7 -#define R1BIO_WriteError 8 + R1BIO_MadeGood, + R1BIO_WriteError, +}; #endif |