diff options
| author |   Damien Le Moal <damien.lemoal@wdc.com> | 2020-07-16 13:54:42 +0900 |
|---|---|---|
| committer |   Song Liu <songliubraving@fb.com> | 2020-07-15 22:46:07 -0700 |
| commit | 2aada5b14bd0db76fb28885cbb22ce893b0654c8 (patch) | |
| tree | 75a5616bfc22ece0217345dec5621c90603af74e /drivers/md/raid5.c | |
| parent | md: raid5-cache: Remove set but unused variable (diff) | |
| download | linux-dev-2aada5b14bd0db76fb28885cbb22ce893b0654c8.tar.xz linux-dev-2aada5b14bd0db76fb28885cbb22ce893b0654c8.zip | |
md: raid5: Fix compilation warning
Remove the if statement around the calls to sysfs_link_rdev() to avoid
the compilation warning "suggest braces around empty body in an ‘if’
statement" when compiling with W=1.
Also fix function description comments to avoid kdoc format warnings.
Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
Signed-off-by: Song Liu <songliubraving@fb.com>
Diffstat (limited to 'drivers/md/raid5.c')
| -rw-r--r-- | drivers/md/raid5.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c index a4fbafa5b8f8..2dad541a60da 100644 --- a/drivers/md/raid5.c +++ b/drivers/md/raid5.c @@ -2217,9 +2217,9 @@ static int grow_stripes(struct r5conf *conf, int num) /** * scribble_alloc - allocate percpu scribble buffer for required size * of the scribble region - * @percpu - from for_each_present_cpu() of the caller - * @num - total number of disks in the array - * @cnt - scribble objs count for required size of the scribble region + * @percpu: from for_each_present_cpu() of the caller + * @num: total number of disks in the array + * @cnt: scribble objs count for required size of the scribble region * * The scribble buffer size must be enough to contain: * 1/ a struct page pointer for each device in the array +2 @@ -3710,7 +3710,7 @@ static int fetch_block(struct stripe_head *sh, struct stripe_head_state *s, return 0; } -/** +/* * handle_stripe_fill - read or compute data to satisfy pending requests. */ static void handle_stripe_fill(struct stripe_head *sh, @@ -7944,8 +7944,8 @@ static int raid5_start_reshape(struct mddev *mddev) else rdev->recovery_offset = 0; - if (sysfs_link_rdev(mddev, rdev)) - /* Failure here is OK */; + /* Failure here is OK */ + sysfs_link_rdev(mddev, rdev); } } else if (rdev->raid_disk >= conf->previous_raid_disks && !test_bit(Faulty, &rdev->flags)) { |