diff options
| author |   Zhao Heming <heming.zhao@suse.com> | 2020-09-27 13:40:13 +0800 |
|---|---|---|
| committer |   Song Liu <songliubraving@fb.com> | 2020-10-08 22:37:39 -0700 |
| commit | 1383b347a8ae4a69c04ae3746e6cb5c8d38e2585 (patch) | |
| tree | fb317ba8ce53d83ed433af06609dada44bdc3809 /drivers/md | |
| parent | md: fix the checking of wrong work queue (diff) | |
| download | linux-dev-1383b347a8ae4a69c04ae3746e6cb5c8d38e2585.tar.xz linux-dev-1383b347a8ae4a69c04ae3746e6cb5c8d38e2585.zip | |
md/bitmap: fix memory leak of temporary bitmap
Callers of get_bitmap_from_slot() are responsible to free the bitmap.
Suggested-by: Guoqing Jiang <guoqing.jiang@cloud.ionos.com>
Signed-off-by: Zhao Heming <heming.zhao@suse.com>
Signed-off-by: Song Liu <songliubraving@fb.com>
Diffstat (limited to 'drivers/md')
| -rw-r--r-- | drivers/md/md-bitmap.c | 3 | ||||
| -rw-r--r-- | drivers/md/md-cluster.c | 1 |
2 files changed, 3 insertions, 1 deletions
diff --git a/drivers/md/md-bitmap.c b/drivers/md/md-bitmap.c index b3f13105659d..200c5d0f08bf 100644 --- a/drivers/md/md-bitmap.c +++ b/drivers/md/md-bitmap.c @@ -1950,6 +1950,7 @@ out: } EXPORT_SYMBOL_GPL(md_bitmap_load); +/* caller need to free returned bitmap with md_bitmap_free() */ struct bitmap *get_bitmap_from_slot(struct mddev *mddev, int slot) { int rv = 0; @@ -2013,6 +2014,7 @@ int md_bitmap_copy_from_slot(struct mddev *mddev, int slot, md_bitmap_unplug(mddev->bitmap); *low = lo; *high = hi; + md_bitmap_free(bitmap); return rv; } @@ -2616,4 +2618,3 @@ struct attribute_group md_bitmap_group = { .name = "bitmap", .attrs = md_bitmap_attrs, }; - diff --git a/drivers/md/md-cluster.c b/drivers/md/md-cluster.c index 0580b51a156a..4aaf4820b6f6 100644 --- a/drivers/md/md-cluster.c +++ b/drivers/md/md-cluster.c @@ -1166,6 +1166,7 @@ static int resize_bitmaps(struct mddev *mddev, sector_t newsize, sector_t oldsiz * can't resize bitmap */ goto out; + md_bitmap_free(bitmap); } return 0; |