diff options
| author |   Coly Li <colyli@suse.de> | 2019-02-09 12:53:04 +0800 |
|---|---|---|
| committer |   Jens Axboe <axboe@kernel.dk> | 2019-02-09 07:18:32 -0700 |
| commit | 369d21a73a241682de019ac5c5209ce3ec627743 (patch) | |
| tree | c977a41c6a5ea172c9fc8057615b957ff0b17cb9 /drivers/md | |
| parent | bcache: use sysfs_strtoul_bool() to set bit-field variables (diff) | |
| download | linux-dev-369d21a73a241682de019ac5c5209ce3ec627743.tar.xz linux-dev-369d21a73a241682de019ac5c5209ce3ec627743.zip | |
bcache: fix input overflow to writeback_delay
Sysfs file writeback_delay is used to configure dc->writeback_delay
which is type unsigned int. But bcache code uses sysfs_strtoul() to
convert the input string, therefore it might be overflowed if the input
value is too large. E.g. input value is 4294967296 but indeed 0 is
set to dc->writeback_delay.
This patch uses sysfs_strtoul_clamp() to convert the input string and
set the result value range in [0, UINT_MAX] to avoid such unsigned
integer overflow.
Signed-off-by: Coly Li <colyli@suse.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'drivers/md')
| -rw-r--r-- | drivers/md/bcache/sysfs.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/md/bcache/sysfs.c b/drivers/md/bcache/sysfs.c index 57395e23747a..e4519326594f 100644 --- a/drivers/md/bcache/sysfs.c +++ b/drivers/md/bcache/sysfs.c @@ -280,7 +280,7 @@ STORE(__cached_dev) sysfs_strtoul_bool(bypass_torture_test, dc->bypass_torture_test); sysfs_strtoul_bool(writeback_metadata, dc->writeback_metadata); sysfs_strtoul_bool(writeback_running, dc->writeback_running); - d_strtoul(writeback_delay); + sysfs_strtoul_clamp(writeback_delay, dc->writeback_delay, 0, UINT_MAX); sysfs_strtoul_clamp(writeback_percent, dc->writeback_percent, 0, bch_cutoff_writeback); |