diff options
| author |   Christoph Hellwig <hch@lst.de> | 2017-01-03 14:52:44 +0300 |
|---|---|---|
| committer |   Jens Axboe <axboe@fb.com> | 2017-01-27 15:08:35 -0700 |
| commit | 5ea708d15a928f7a479987704203616d3274c03b (patch) | |
| tree | 0b1595694cc628134ccb108f256beed8831887bf /drivers/md | |
| parent | block: fix elevator init check (diff) | |
| download | linux-dev-5ea708d15a928f7a479987704203616d3274c03b.tar.xz linux-dev-5ea708d15a928f7a479987704203616d3274c03b.zip | |
block: simplify blk_init_allocated_queue
Return an errno value instead of the passed in queue so that the callers
don't have to keep track of two queues, and move the assignment of the
request_fn and lock to the caller as passing them as argument doesn't
simplify anything. While we're at it also remove two pointless NULL
assignments, given that the request structure is zeroed on allocation.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
Diffstat (limited to 'drivers/md')
| -rw-r--r-- | drivers/md/dm-rq.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/md/dm-rq.c b/drivers/md/dm-rq.c index 9d7275fb541a..93f6e9f1ebe2 100644 --- a/drivers/md/dm-rq.c +++ b/drivers/md/dm-rq.c @@ -823,7 +823,8 @@ static void dm_old_request_fn(struct request_queue *q) int dm_old_init_request_queue(struct mapped_device *md) { /* Fully initialize the queue */ - if (!blk_init_allocated_queue(md->queue, dm_old_request_fn, NULL)) + md->queue->request_fn = dm_old_request_fn; + if (blk_init_allocated_queue(md->queue) < 0) return -EINVAL; /* disable dm_old_request_fn's merge heuristic by default */ |