diff options
| author |   Heinz Mauelshagen <heinzm@redhat.com> | 2018-12-18 17:35:41 +0100 |
|---|---|---|
| committer |   Mike Snitzer <snitzer@redhat.com> | 2018-12-18 13:48:35 -0500 |
| commit | 74694bcbdf7e28a5ad548cdda9ac56d30be00d13 (patch) | |
| tree | 44eabdc82e3b9ac13159650576f06c0b71f523f1 /drivers/md | |
| parent | dm rq: cleanup leftover code from recently removed q->mq_ops branching (diff) | |
| download | linux-dev-74694bcbdf7e28a5ad548cdda9ac56d30be00d13.tar.xz linux-dev-74694bcbdf7e28a5ad548cdda9ac56d30be00d13.zip | |
dm raid: fix false -EBUSY when handling check/repair message
Sending a check/repair message infrequently leads to -EBUSY instead of
properly identifying an active resync. This occurs because
raid_message() is testing recovery bits in a racy way.
Fix by calling decipher_sync_action() from raid_message() to properly
identify the idle state of the RAID device.
Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Diffstat (limited to 'drivers/md')
| -rw-r--r-- | drivers/md/dm-raid.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c index e1dd1622a290..adcfe8ae10aa 100644 --- a/drivers/md/dm-raid.c +++ b/drivers/md/dm-raid.c @@ -3690,8 +3690,7 @@ static int raid_message(struct dm_target *ti, unsigned int argc, char **argv, set_bit(MD_RECOVERY_INTR, &mddev->recovery); md_reap_sync_thread(mddev); } - } else if (test_bit(MD_RECOVERY_RUNNING, &mddev->recovery) || - test_bit(MD_RECOVERY_NEEDED, &mddev->recovery)) + } else if (decipher_sync_action(mddev, mddev->recovery) != st_idle) return -EBUSY; else if (!strcasecmp(argv[0], "resync")) ; /* MD_RECOVERY_NEEDED set below */ |