diff options
| author |   NeilBrown <neilb@suse.de> | 2011-08-30 16:20:17 +1000 |
|---|---|---|
| committer | NeilBrown <neilb@suse.de> | 2011-08-30 16:20:17 +1000 |
| commit | 7da64a0abc3b2c6cbd3521672e9bb74dd560bb89 (patch) | |
| tree | 1b17033fe40a2b29c7e4d6a2f200f54f39514a4d /drivers/md | |
| parent | md/linear: avoid corrupting structure while waiting for rcu_free to complete. (diff) | |
| download | linux-dev-7da64a0abc3b2c6cbd3521672e9bb74dd560bb89.tar.xz linux-dev-7da64a0abc3b2c6cbd3521672e9bb74dd560bb89.zip | |
md: fix clearing of 'blocked' flag in the presence of bad blocks.
When the 'blocked' flag on a device is cleared while there are
unacknowledged bad blocks we must fail the device. This is needed for
backwards compatability of the interface.
The code currently uses the wrong test for "unacknowledged bad blocks
exist". Change it to the right test.
Signed-off-by: NeilBrown <neilb@suse.de>
Diffstat (limited to 'drivers/md')
| -rw-r--r-- | drivers/md/md.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/md/md.c b/drivers/md/md.c index aca611711264..3742ce8b0acf 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -2592,7 +2592,7 @@ state_store(mdk_rdev_t *rdev, const char *buf, size_t len) err = 0; } else if (cmd_match(buf, "-blocked")) { if (!test_bit(Faulty, &rdev->flags) && - test_bit(BlockedBadBlocks, &rdev->flags)) { + rdev->badblocks.unacked_exist) { /* metadata handler doesn't understand badblocks, * so we need to fail the device */ |