diff options
| author |   NeilBrown <neilb@suse.de> | 2011-12-23 10:17:52 +1100 |
|---|---|---|
| committer | NeilBrown <neilb@suse.de> | 2011-12-23 10:17:52 +1100 |
| commit | 995c4275a7e14b8752f301e4570831a108ae4303 (patch) | |
| tree | 2bee4c8daf14b6453371bb348b18d37d7e3cdb07 /drivers/md | |
| parent | md/raid5: raid5.h cleanup (diff) | |
| download | linux-dev-995c4275a7e14b8752f301e4570831a108ae4303.tar.xz linux-dev-995c4275a7e14b8752f301e4570831a108ae4303.zip | |
md/raid5: remove redundant bio initialisations.
We current initialise some fields of a bio when preparing a
stripe_head, and again just before submitting the request.
Remove the duplication by only setting the fields that lower level
devices don't touch in raid5_build_block, and only set the changeable
fields in ops_run_io.
Reviewed-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: NeilBrown <neilb@suse.de>
Diffstat (limited to 'drivers/md')
| -rw-r--r-- | drivers/md/raid5.c | 9 |
1 files changed, 1 insertions, 8 deletions
diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c index 94bc35ba4c81..2d2aaf6e98e2 100644 --- a/drivers/md/raid5.c +++ b/drivers/md/raid5.c @@ -574,10 +574,7 @@ static void ops_run_io(struct stripe_head *sh, struct stripe_head_state *s) atomic_inc(&sh->count); bi->bi_sector = sh->sector + rdev->data_offset; bi->bi_flags = 1 << BIO_UPTODATE; - bi->bi_vcnt = 1; - bi->bi_max_vecs = 1; bi->bi_idx = 0; - bi->bi_io_vec = &sh->dev[i].vec; bi->bi_io_vec[0].bv_len = STRIPE_SIZE; bi->bi_io_vec[0].bv_offset = 0; bi->bi_size = STRIPE_SIZE; @@ -1720,12 +1717,8 @@ static void raid5_build_block(struct stripe_head *sh, int i, int previous) dev->req.bi_io_vec = &dev->vec; dev->req.bi_vcnt++; dev->req.bi_max_vecs++; - dev->vec.bv_page = dev->page; - dev->vec.bv_len = STRIPE_SIZE; - dev->vec.bv_offset = 0; - - dev->req.bi_sector = sh->sector; dev->req.bi_private = sh; + dev->vec.bv_page = dev->page; dev->flags = 0; dev->sector = compute_blocknr(sh, i, previous); |