aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/md
diff options
context:
space:
mode:
authorColy Li <colyli@suse.de>2019-04-30 22:02:25 +0800
committerJens Axboe <axboe@kernel.dk>2019-04-30 08:20:46 -0600
commitcdca22bcbc64fc83dadb8d927df400a8d86ddabb (patch)
tree4dc562ec8fb0d7e8eb424930daf581647049a82b /drivers/md
parentMerge branch 'nvme-5.2' of git://git.infradead.org/nvme into for-5.2/block (diff)
downloadlinux-dev-cdca22bcbc64fc83dadb8d927df400a8d86ddabb.tar.xz
linux-dev-cdca22bcbc64fc83dadb8d927df400a8d86ddabb.zip
bcache: remove redundant LIST_HEAD(journal) from run_cache_set()
Commit 95f18c9d1310 ("bcache: avoid potential memleak of list of journal_replay(s) in the CACHE_SYNC branch of run_cache_set") forgets to remove the original define of LIST_HEAD(journal), which makes the change no take effect. This patch removes redundant variable LIST_HEAD(journal) from run_cache_set(), to make Shenghui's fix working. Fixes: 95f18c9d1310 ("bcache: avoid potential memleak of list of journal_replay(s) in the CACHE_SYNC branch of run_cache_set") Reported-by: Juha Aatrokoski <juha.aatrokoski@aalto.fi> Cc: Shenghui Wang <shhuiw@foxmail.com> Signed-off-by: Coly Li <colyli@suse.de> Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'drivers/md')
-rw-r--r--drivers/md/bcache/super.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
index 0ffe9acee9d8..1b63ac876169 100644
--- a/drivers/md/bcache/super.c
+++ b/drivers/md/bcache/super.c
@@ -1800,7 +1800,6 @@ static int run_cache_set(struct cache_set *c)
set_gc_sectors(c);
if (CACHE_SYNC(&c->sb)) {
- LIST_HEAD(journal);
struct bkey *k;
struct jset *j;