diff options
| author |   Antti Palosaari <crope@iki.fi> | 2014-12-05 14:30:44 -0300 |
|---|---|---|
| committer |   Mauro Carvalho Chehab <mchehab@osg.samsung.com> | 2015-01-29 18:41:11 -0200 |
| commit | 4affbe1d0825dc3c9c5fcec8a4848d8bbdd718cb (patch) | |
| tree | f428591902da5d392758588be91dfc5ab111d630 /drivers/media/dvb-frontends/si2168.c | |
| parent | [media] si2168: get rid of own struct i2c_client pointer (diff) | |
| download | linux-dev-4affbe1d0825dc3c9c5fcec8a4848d8bbdd718cb.tar.xz linux-dev-4affbe1d0825dc3c9c5fcec8a4848d8bbdd718cb.zip | |
[media] si2168: simplify si2168_cmd_execute() error path
Remove if () from firmware command error path as there should not be
any error prone conditional logic there. Use goto labels instead.
Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Diffstat (limited to 'drivers/media/dvb-frontends/si2168.c')
| -rw-r--r-- | drivers/media/dvb-frontends/si2168.c | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/drivers/media/dvb-frontends/si2168.c b/drivers/media/dvb-frontends/si2168.c index e00bc0467356..3c102e519312 100644 --- a/drivers/media/dvb-frontends/si2168.c +++ b/drivers/media/dvb-frontends/si2168.c @@ -66,15 +66,11 @@ static int si2168_cmd_execute(struct i2c_client *client, struct si2168_cmd *cmd) } } - ret = 0; + mutex_unlock(&dev->i2c_mutex); + return 0; err_mutex_unlock: mutex_unlock(&dev->i2c_mutex); - if (ret) - goto err; - - return 0; -err: dev_dbg(&client->dev, "failed=%d\n", ret); return ret; } |