diff options
| author |   Sakari Ailus <sakari.ailus@linux.intel.com> | 2018-09-24 10:24:43 -0400 |
|---|---|---|
| committer |   Mauro Carvalho Chehab <mchehab+samsung@kernel.org> | 2018-10-03 11:55:44 -0400 |
| commit | 654be7dde76b1897450c49d526af11067601e5b9 (patch) | |
| tree | a1e6e53992bfc878dd8ba2ff34743a18082f90f9 /drivers/media/i2c/s5k6aa.c | |
| parent | media: davinci: Fix implicit enum conversion warning (diff) | |
| download | linux-dev-654be7dde76b1897450c49d526af11067601e5b9.tar.xz linux-dev-654be7dde76b1897450c49d526af11067601e5b9.zip | |
media: v4l: i2c: Add a comment not to use static sub-device names in the future
A number of sub-device drivers used a static name for the sub-device, and
thus the media entity. As the entity name must be unique within a media
device, this makes it impossible to have more than one instance of each
device in a media device. This is a rather severe limitation.
Instead of fixing these drivers, add a comment to the drivers noting that
such static names may not be used in the future.
The alternative of fixing the drivers is troublesome as the entity (as
well as sub-device) name is part of the uAPI. Changing that is almost
certain to break something. As these devices are old but no-one has
encountered a problem with the static names, leave it as-is.
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Diffstat (limited to 'drivers/media/i2c/s5k6aa.c')
| -rw-r--r-- | drivers/media/i2c/s5k6aa.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/media/i2c/s5k6aa.c b/drivers/media/i2c/s5k6aa.c index 52ca033f7069..63cf8db82e7d 100644 --- a/drivers/media/i2c/s5k6aa.c +++ b/drivers/media/i2c/s5k6aa.c @@ -1576,6 +1576,7 @@ static int s5k6aa_probe(struct i2c_client *client, sd = &s5k6aa->sd; v4l2_i2c_subdev_init(sd, client, &s5k6aa_subdev_ops); + /* Static name; NEVER use in new drivers! */ strscpy(sd->name, DRIVER_NAME, sizeof(sd->name)); sd->internal_ops = &s5k6aa_subdev_internal_ops; |