diff options
| author |   Christoph Hellwig <hch@lst.de> | 2015-11-20 15:57:07 -0800 |
|---|---|---|
| committer |   Linus Torvalds <torvalds@linux-foundation.org> | 2015-11-20 16:17:32 -0800 |
| commit | 1a47de6e4a8dc2aaf3c3fb544b60730b74abe0f1 (patch) | |
| tree | 0882cd3057a935843aed8fd5d343df348adf8e99 /drivers/media/pci/netup_unidvb | |
| parent | mm: loosen MADV_NOHUGEPAGE to enable Qemu postcopy on s390 (diff) | |
| download | linux-dev-1a47de6e4a8dc2aaf3c3fb544b60730b74abe0f1.tar.xz linux-dev-1a47de6e4a8dc2aaf3c3fb544b60730b74abe0f1.zip | |
various: fix pci_set_dma_mask return value checking
pci_set_dma_mask returns a negative errno value, not a bool like
pci_dma_supported. This of course was just a giant test for attention :)
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reported-by: Jongman Heo <jongman.heo@samsung.com>
Tested-by: Jongman Heo <jongman.heo@samsung.com> [pcnet32]
Acked-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Cc: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Antti Palosaari <crope@iki.fi>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/media/pci/netup_unidvb')
| -rw-r--r-- | drivers/media/pci/netup_unidvb/netup_unidvb_core.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/media/pci/netup_unidvb/netup_unidvb_core.c b/drivers/media/pci/netup_unidvb/netup_unidvb_core.c index 60b2d462f98d..3fdbd81b5580 100644 --- a/drivers/media/pci/netup_unidvb/netup_unidvb_core.c +++ b/drivers/media/pci/netup_unidvb/netup_unidvb_core.c @@ -810,7 +810,7 @@ static int netup_unidvb_initdev(struct pci_dev *pci_dev, "%s(): board vendor 0x%x, revision 0x%x\n", __func__, board_vendor, board_revision); pci_set_master(pci_dev); - if (!pci_set_dma_mask(pci_dev, 0xffffffff)) { + if (pci_set_dma_mask(pci_dev, 0xffffffff) < 0) { dev_err(&pci_dev->dev, "%s(): 32bit PCI DMA is not supported\n", __func__); goto pci_detect_err; |