aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/media/platform
diff options
context:
space:
mode:
authorDinghao Liu <dinghao.liu@zju.edu.cn>2021-04-07 07:43:13 +0200
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>2021-04-09 12:55:05 +0200
commit69306a947b3ae21e0d1cbfc9508f00fec86c7297 (patch)
treeccf9ab300bffd1dbbd74ee7e1b45c080b7b2ba1b /drivers/media/platform
parentmedia: imx-jpeg: Fix double free in mxc_jpeg_remove (diff)
downloadlinux-dev-69306a947b3ae21e0d1cbfc9508f00fec86c7297.tar.xz
linux-dev-69306a947b3ae21e0d1cbfc9508f00fec86c7297.zip
media: platform: sti: Fix runtime PM imbalance in regs_show
pm_runtime_get_sync() will increase the runtime PM counter even it returns an error. Thus a pairing decrement is needed to prevent refcount leak. Fix this by replacing this API with pm_runtime_resume_and_get(), which will not change the runtime PM counter on error. Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Diffstat (limited to 'drivers/media/platform')
-rw-r--r--drivers/media/platform/sti/bdisp/bdisp-debug.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/media/platform/sti/bdisp/bdisp-debug.c b/drivers/media/platform/sti/bdisp/bdisp-debug.c
index 2b270093009c..a27f638df11c 100644
--- a/drivers/media/platform/sti/bdisp/bdisp-debug.c
+++ b/drivers/media/platform/sti/bdisp/bdisp-debug.c
@@ -480,7 +480,7 @@ static int regs_show(struct seq_file *s, void *data)
int ret;
unsigned int i;
- ret = pm_runtime_get_sync(bdisp->dev);
+ ret = pm_runtime_resume_and_get(bdisp->dev);
if (ret < 0) {
seq_puts(s, "Cannot wake up IP\n");
return 0;