diff options
| author |   Johan Hovold <johan@kernel.org> | 2019-10-10 10:13:32 -0300 |
|---|---|---|
| committer |   Mauro Carvalho Chehab <mchehab@kernel.org> | 2019-11-05 08:50:34 -0300 |
| commit | 1091eb830627625dcf79958d99353c2391f41708 (patch) | |
| tree | a608497789c10cd228f6bf09f0601d2bce685b6e /drivers/media/radio | |
| parent | media: bdisp: fix memleak on release (diff) | |
| download | linux-dev-1091eb830627625dcf79958d99353c2391f41708.tar.xz linux-dev-1091eb830627625dcf79958d99353c2391f41708.zip | |
media: radio: wl1273: fix interrupt masking on release
If a process is interrupted while accessing the radio device and the
core lock is contended, release() could return early and fail to update
the interrupt mask.
Note that the return value of the v4l2 release file operation is
ignored.
Fixes: 87d1a50ce451 ("[media] V4L2: WL1273 FM Radio: TI WL1273 FM radio driver")
Cc: stable <stable@vger.kernel.org> # 2.6.38
Cc: Matti Aaltonen <matti.j.aaltonen@nokia.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Diffstat (limited to 'drivers/media/radio')
| -rw-r--r-- | drivers/media/radio/radio-wl1273.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/media/radio/radio-wl1273.c b/drivers/media/radio/radio-wl1273.c index 104ac41c6f96..112376873167 100644 --- a/drivers/media/radio/radio-wl1273.c +++ b/drivers/media/radio/radio-wl1273.c @@ -1148,8 +1148,7 @@ static int wl1273_fm_fops_release(struct file *file) if (radio->rds_users > 0) { radio->rds_users--; if (radio->rds_users == 0) { - if (mutex_lock_interruptible(&core->lock)) - return -EINTR; + mutex_lock(&core->lock); radio->irq_flags &= ~WL1273_RDS_EVENT; |