diff options
| author |   Samuel Holland <samuel@sholland.org> | 2021-01-18 07:00:45 +0100 |
|---|---|---|
| committer |   Mauro Carvalho Chehab <mchehab+huawei@kernel.org> | 2021-01-27 08:25:36 +0100 |
| commit | 586bb700b3256a1cb38935f83c76e6522ac53d64 (patch) | |
| tree | 82d65e1db01915a201a8b8f40508e3d32d478342 /drivers/media/rc/sunxi-cir.c | |
| parent | media: ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver (diff) | |
| download | linux-dev-586bb700b3256a1cb38935f83c76e6522ac53d64.tar.xz linux-dev-586bb700b3256a1cb38935f83c76e6522ac53d64.zip | |
media: sunxi-cir: Clean up dead register writes
The register writes during driver removal occur after the device is
already put back in reset, so they never had any effect.
Acked-by: Maxime Ripard <mripard@kernel.org>
Signed-off-by: Samuel Holland <samuel@sholland.org>
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Diffstat (limited to 'drivers/media/rc/sunxi-cir.c')
| -rw-r--r-- | drivers/media/rc/sunxi-cir.c | 10 |
1 files changed, 0 insertions, 10 deletions
diff --git a/drivers/media/rc/sunxi-cir.c b/drivers/media/rc/sunxi-cir.c index 8555c7798706..0a7f7eab3cc3 100644 --- a/drivers/media/rc/sunxi-cir.c +++ b/drivers/media/rc/sunxi-cir.c @@ -342,22 +342,12 @@ exit_reset_assert: static int sunxi_ir_remove(struct platform_device *pdev) { - unsigned long flags; struct sunxi_ir *ir = platform_get_drvdata(pdev); clk_disable_unprepare(ir->clk); clk_disable_unprepare(ir->apb_clk); reset_control_assert(ir->rst); - spin_lock_irqsave(&ir->ir_lock, flags); - /* disable IR IRQ */ - writel(0, ir->base + SUNXI_IR_RXINT_REG); - /* clear All Rx Interrupt Status */ - writel(REG_RXSTA_CLEARALL, ir->base + SUNXI_IR_RXSTA_REG); - /* disable IR */ - writel(0, ir->base + SUNXI_IR_CTL_REG); - spin_unlock_irqrestore(&ir->ir_lock, flags); - rc_unregister_device(ir->rc); return 0; } |