diff options
| author |   Neil Armstrong <narmstrong@baylibre.com> | 2018-11-08 07:44:48 -0500 |
|---|---|---|
| committer |   Mauro Carvalho Chehab <mchehab+samsung@kernel.org> | 2018-12-03 13:26:48 -0500 |
| commit | 458ffce1cb46e46e3cec48b625ed142250475708 (patch) | |
| tree | b1f5237f73c63d3b77528f0642b8abef7988a2b4 /drivers/media/spi | |
| parent | media: dvb: Use WARM definition from identify_state() (diff) | |
| download | linux-dev-458ffce1cb46e46e3cec48b625ed142250475708.tar.xz linux-dev-458ffce1cb46e46e3cec48b625ed142250475708.zip | |
media: cxd2880-spi: fix probe when dvb_attach fails
When dvb_attach fails, probe returns 0, and remove crashes afterwards.
This patch sets the return value to -ENODEV when attach fails.
Fixes: bd24fcddf6b8 ("media: cxd2880-spi: Add support for CXD2880 SPI interface")
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Acked-by: Yasunari Takiguchi <Yasunari.Takiguchi@sony.com>
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Diffstat (limited to 'drivers/media/spi')
| -rw-r--r-- | drivers/media/spi/cxd2880-spi.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/media/spi/cxd2880-spi.c b/drivers/media/spi/cxd2880-spi.c index 11ce5101e19f..c43730977f53 100644 --- a/drivers/media/spi/cxd2880-spi.c +++ b/drivers/media/spi/cxd2880-spi.c @@ -536,6 +536,7 @@ cxd2880_spi_probe(struct spi_device *spi) if (!dvb_attach(cxd2880_attach, &dvb_spi->dvb_fe, &config)) { pr_err("cxd2880_attach failed\n"); + ret = -ENODEV; goto fail_attach; } |