aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/media/tuners/xc5000.c
diff options
context:
space:
mode:
authorMarkus Elfring <elfring@users.sourceforge.net>2014-11-30 15:05:48 -0300
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>2014-12-04 15:28:51 -0200
commitdc89cfcf33bfd15ad335207062c1f87b6074f222 (patch)
tree34c2d38cefba33b7c71be709cc0c31c4a10642f5 /drivers/media/tuners/xc5000.c
parent[media] arm: omap2: rx51-peripherals: fix build warning (diff)
downloadlinux-dev-dc89cfcf33bfd15ad335207062c1f87b6074f222.tar.xz
linux-dev-dc89cfcf33bfd15ad335207062c1f87b6074f222.zip
[media] tuners: remove uneeded checks before release_firmware()
The release_firmware() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Diffstat (limited to 'drivers/media/tuners/xc5000.c')
-rw-r--r--drivers/media/tuners/xc5000.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/media/tuners/xc5000.c b/drivers/media/tuners/xc5000.c
index 705c258d1101..2a039de8ab9a 100644
--- a/drivers/media/tuners/xc5000.c
+++ b/drivers/media/tuners/xc5000.c
@@ -1336,8 +1336,7 @@ static int xc5000_release(struct dvb_frontend *fe)
if (priv) {
cancel_delayed_work(&priv->timer_sleep);
- if (priv->firmware)
- release_firmware(priv->firmware);
+ release_firmware(priv->firmware);
hybrid_tuner_release_state(priv);
}