diff options
| author |   Hans Petter Selasky <hps@selasky.org> | 2019-01-25 08:01:46 -0500 |
|---|---|---|
| committer |   Mauro Carvalho Chehab <mchehab+samsung@kernel.org> | 2019-03-19 16:33:46 -0400 |
| commit | e7dd89cef16021ad0dd5a590d3d2090bf65e3ec2 (patch) | |
| tree | 5561f46ece2e6ae9308dcf9a3cd55607643f4f80 /drivers/media/v4l2-core/v4l2-ioctl.c | |
| parent | media: vimc: stream: init/terminate the first entity (diff) | |
| download | linux-dev-e7dd89cef16021ad0dd5a590d3d2090bf65e3ec2.tar.xz linux-dev-e7dd89cef16021ad0dd5a590d3d2090bf65e3ec2.zip | |
media: strscpy() returns a negative value on failure unlike strlcpy().
strscpy() returns a negative value on failure unlike strlcpy(),
so fix the WARN_ON accordingly.
Signed-off-by: Hans Petter Selasky <hps@selasky.org>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
[hverkuil-cisco@xs4all.nl: added commit message]
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Diffstat (limited to 'drivers/media/v4l2-core/v4l2-ioctl.c')
| -rw-r--r-- | drivers/media/v4l2-core/v4l2-ioctl.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c index f6d663934648..038739584a84 100644 --- a/drivers/media/v4l2-core/v4l2-ioctl.c +++ b/drivers/media/v4l2-core/v4l2-ioctl.c @@ -1373,7 +1373,7 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt) } if (descr) - WARN_ON(strscpy(fmt->description, descr, sz) >= sz); + WARN_ON(strscpy(fmt->description, descr, sz) < 0); fmt->flags = flags; } |