aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/media
diff options
context:
space:
mode:
authorTodor Tomov <todor.tomov@linaro.org>2018-07-25 12:38:23 -0400
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>2018-08-02 06:16:45 -0400
commit06d690f092db28a7c83c9524010c42136e2bb37f (patch)
treeff5c230ab01b8d00e07ef826154b498e1dc7c142 /drivers/media
parentmedia: camss: vfe: Get line pointer as container of video_out (diff)
downloadlinux-dev-06d690f092db28a7c83c9524010c42136e2bb37f.tar.xz
linux-dev-06d690f092db28a7c83c9524010c42136e2bb37f.zip
media: camss: vfe: Do not disable CAMIF when clearing its status
Use "no change" value when clearing CAMIF status and make sure this is done before configuring the new command. Signed-off-by: Todor Tomov <todor.tomov@linaro.org> Signed-off-by: Hans Verkuil <hansverk@cisco.com> Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Diffstat (limited to 'drivers/media')
-rw-r--r--drivers/media/platform/qcom/camss/camss-vfe.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c b/drivers/media/platform/qcom/camss/camss-vfe.c
index 77167f11b655..15a1a0100ba8 100644
--- a/drivers/media/platform/qcom/camss/camss-vfe.c
+++ b/drivers/media/platform/qcom/camss/camss-vfe.c
@@ -156,6 +156,7 @@
#define VFE_0_CAMIF_CMD 0x2f4
#define VFE_0_CAMIF_CMD_DISABLE_FRAME_BOUNDARY 0
#define VFE_0_CAMIF_CMD_ENABLE_FRAME_BOUNDARY 1
+#define VFE_0_CAMIF_CMD_NO_CHANGE 3
#define VFE_0_CAMIF_CMD_CLEAR_CAMIF_STATUS (1 << 2)
#define VFE_0_CAMIF_CFG 0x2f8
#define VFE_0_CAMIF_CFG_VFE_OUTPUT_EN (1 << 6)
@@ -1021,8 +1022,10 @@ static void vfe_set_camif_cfg(struct vfe_device *vfe, struct vfe_line *line)
static void vfe_set_camif_cmd(struct vfe_device *vfe, u32 cmd)
{
- writel_relaxed(VFE_0_CAMIF_CMD_CLEAR_CAMIF_STATUS,
+ writel_relaxed(VFE_0_CAMIF_CMD_CLEAR_CAMIF_STATUS |
+ VFE_0_CAMIF_CMD_NO_CHANGE,
vfe->base + VFE_0_CAMIF_CMD);
+ wmb();
writel_relaxed(cmd, vfe->base + VFE_0_CAMIF_CMD);
}