diff options
| author |   Johan Hovold <johan@kernel.org> | 2019-10-10 10:13:31 -0300 |
|---|---|---|
| committer |   Mauro Carvalho Chehab <mchehab@kernel.org> | 2019-11-05 08:50:02 -0300 |
| commit | 11609a7e21f8cea42630350aa57662928fa4dc63 (patch) | |
| tree | c84df2fb077822a42f7efef2770444fa42c97487 /drivers/media | |
| parent | media: v4l2-dv-timings: Use DIV_ROUND_CLOSEST directly to make it readable (diff) | |
| download | linux-dev-11609a7e21f8cea42630350aa57662928fa4dc63.tar.xz linux-dev-11609a7e21f8cea42630350aa57662928fa4dc63.zip | |
media: bdisp: fix memleak on release
If a process is interrupted while accessing the video device and the
device lock is contended, release() could return early and fail to free
related resources.
Note that the return value of the v4l2 release file operation is
ignored.
Fixes: 28ffeebbb7bd ("[media] bdisp: 2D blitter driver using v4l2 mem2mem framework")
Cc: stable <stable@vger.kernel.org> # 4.2
Signed-off-by: Johan Hovold <johan@kernel.org>
Reviewed-by: Fabien Dessenne <fabien.dessenne@st.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Diffstat (limited to 'drivers/media')
| -rw-r--r-- | drivers/media/platform/sti/bdisp/bdisp-v4l2.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/media/platform/sti/bdisp/bdisp-v4l2.c b/drivers/media/platform/sti/bdisp/bdisp-v4l2.c index e90f1ba30574..675b5f2b4c2e 100644 --- a/drivers/media/platform/sti/bdisp/bdisp-v4l2.c +++ b/drivers/media/platform/sti/bdisp/bdisp-v4l2.c @@ -651,8 +651,7 @@ static int bdisp_release(struct file *file) dev_dbg(bdisp->dev, "%s\n", __func__); - if (mutex_lock_interruptible(&bdisp->lock)) - return -ERESTARTSYS; + mutex_lock(&bdisp->lock); v4l2_m2m_ctx_release(ctx->fh.m2m_ctx); |