diff options
| author |   Jacopo Mondi <jacopo+renesas@jmondi.org> | 2021-06-16 14:46:06 +0200 |
|---|---|---|
| committer |   Mauro Carvalho Chehab <mchehab+huawei@kernel.org> | 2021-06-17 11:29:27 +0200 |
| commit | 4ff5278dcef900879252556a51b74b33efb06623 (patch) | |
| tree | 0a2875a2a1167b0750379eb05bf19ce2269dab29 /drivers/media | |
| parent | media: i2c: max9286: Define high channel amplitude (diff) | |
| download | linux-dev-4ff5278dcef900879252556a51b74b33efb06623.tar.xz linux-dev-4ff5278dcef900879252556a51b74b33efb06623.zip | |
media: i2c: max9286: Rework comments in .bound()
Rephrase a comment in .bound() callback to make it clear we register
a subdev notifier and remove a redundant comment about disabling i2c
auto-ack.
No functional changes intended.
Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Diffstat (limited to 'drivers/media')
| -rw-r--r-- | drivers/media/i2c/max9286.c | 11 |
1 files changed, 3 insertions, 8 deletions
diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c index b0cd9fc8f7e2..1aa2c58fd38c 100644 --- a/drivers/media/i2c/max9286.c +++ b/drivers/media/i2c/max9286.c @@ -556,9 +556,9 @@ static int max9286_notify_bound(struct v4l2_async_notifier *notifier, subdev->name, src_pad, index); /* - * We can only register v4l2_async_notifiers, which do not provide a - * means to register a complete callback. bound_sources allows us to - * identify when all remote serializers have completed their probe. + * As we register a subdev notifiers we won't get a .complete() callback + * here, so we have to use bound_sources to identify when all remote + * serializers have probed. */ if (priv->bound_sources != priv->source_mask) return 0; @@ -575,11 +575,6 @@ static int max9286_notify_bound(struct v4l2_async_notifier *notifier, */ max9286_reverse_channel_setup(priv, MAX9286_REV_AMP_HIGH); max9286_check_config_link(priv, priv->source_mask); - - /* - * Re-configure I2C with local acknowledge disabled after cameras have - * probed. - */ max9286_configure_i2c(priv, false); return max9286_set_pixelrate(priv); |