diff options
| author |   Janusz Krzysztofik <jmkrzyszt@gmail.com> | 2019-06-02 17:22:15 -0400 |
|---|---|---|
| committer |   Mauro Carvalho Chehab <mchehab+samsung@kernel.org> | 2019-06-21 17:53:25 -0400 |
| commit | 5c49ac3ac6562a39baa2aece050a14b661197036 (patch) | |
| tree | 892aaee709f55490abf0a5271da4ad52e723be44 /drivers/media | |
| parent | media: i2c: Fix Unnecessary Semicolon Warning Reported by coccicheck (diff) | |
| download | linux-dev-5c49ac3ac6562a39baa2aece050a14b661197036.tar.xz linux-dev-5c49ac3ac6562a39baa2aece050a14b661197036.zip | |
media: ov6650: Fix device node exposed without proper locking
Commit c62b96050bee ("media: ov6650: Register with asynchronous
subdevice framework") carelessly requested creation of a video device
node by setting a V4L2_SUBDEV_FL_HAS_DEVNODE flag. The driver is not
ready for that as it doesn't implement proper locking required for
serialization of IOCTLs.
Fix it by dropping the flag assignment.
Fixes: c62b96050bee ("media: ov6650: Register with asynchronous subdevice framework")
Signed-off-by: Janusz Krzysztofik <jmkrzyszt@gmail.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Diffstat (limited to 'drivers/media')
| -rw-r--r-- | drivers/media/i2c/ov6650.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/media/i2c/ov6650.c b/drivers/media/i2c/ov6650.c index 1b972e591b48..ace95ba7dd19 100644 --- a/drivers/media/i2c/ov6650.c +++ b/drivers/media/i2c/ov6650.c @@ -1009,7 +1009,6 @@ static int ov6650_probe(struct i2c_client *client, priv->colorspace = V4L2_COLORSPACE_JPEG; priv->subdev.internal_ops = &ov6650_internal_ops; - priv->subdev.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE; ret = v4l2_async_register_subdev(&priv->subdev); if (ret) |