diff options
| author |   Krzysztof Kozlowski <krzk@kernel.org> | 2020-08-28 17:37:46 +0200 |
|---|---|---|
| committer | Krzysztof Kozlowski <krzk@kernel.org> | 2020-09-02 17:22:31 +0200 |
| commit | 74ca0d837b99b0ca6e66861a64a6456beaa10298 (patch) | |
| tree | 86264b392f18b57fc580c46bb5499239a00b454f /drivers/memory/brcmstb_dpfe.c | |
| parent | memory: samsung: exynos5422-dmc: add missing and fix kerneldoc (diff) | |
| download | linux-dev-74ca0d837b99b0ca6e66861a64a6456beaa10298.tar.xz linux-dev-74ca0d837b99b0ca6e66861a64a6456beaa10298.zip | |
memory: brcmstb_dpfe: Simplify with dev_err_probe()
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and the error value gets printed.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Acked-by: Markus Mayer <mmayer@broadcom.com>
Link: https://lore.kernel.org/r/20200828153747.22358-1-krzk@kernel.org
Diffstat (limited to 'drivers/memory/brcmstb_dpfe.c')
| -rw-r--r-- | drivers/memory/brcmstb_dpfe.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/drivers/memory/brcmstb_dpfe.c b/drivers/memory/brcmstb_dpfe.c index dcf50bb8dd69..f43ba69fbb3e 100644 --- a/drivers/memory/brcmstb_dpfe.c +++ b/drivers/memory/brcmstb_dpfe.c @@ -901,11 +901,8 @@ static int brcmstb_dpfe_probe(struct platform_device *pdev) } ret = brcmstb_dpfe_download_firmware(priv); - if (ret) { - if (ret != -EPROBE_DEFER) - dev_err(dev, "Couldn't download firmware -- %d\n", ret); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "Couldn't download firmware\n"); ret = sysfs_create_groups(&pdev->dev.kobj, priv->dpfe_api->sysfs_attrs); if (!ret) |