aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/memory
diff options
context:
space:
mode:
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>2017-05-25 22:07:13 +0200
committerTony Lindgren <tony@atomide.com>2017-05-31 10:08:10 -0700
commitc9eabf40d91b4fe954efe380d88590d933baa06d (patch)
tree9efbadb96cc9b48145463c7ae3c8b20469567213 /drivers/memory
parentmemory: omap-gpmc: make dts snippet include semicolon (diff)
downloadlinux-dev-c9eabf40d91b4fe954efe380d88590d933baa06d.tar.xz
linux-dev-c9eabf40d91b4fe954efe380d88590d933baa06d.zip
memory: omap-gpmc: add error message if bank-width property is absent
Instead of failing silently log a hint for the dt author about the reason of the failure. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Acked-by: Roger Quadros <rogerq@ti.com> Signed-off-by: Tony Lindgren <tony@atomide.com>
Diffstat (limited to 'drivers/memory')
-rw-r--r--drivers/memory/omap-gpmc.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c
index 44b79db20021..2a46e6fd7d47 100644
--- a/drivers/memory/omap-gpmc.c
+++ b/drivers/memory/omap-gpmc.c
@@ -2083,8 +2083,11 @@ static int gpmc_probe_generic_child(struct platform_device *pdev,
} else {
ret = of_property_read_u32(child, "bank-width",
&gpmc_s.device_width);
- if (ret < 0)
+ if (ret < 0) {
+ dev_err(&pdev->dev, "%s has no 'bank-width' property\n",
+ child->full_name);
goto err;
+ }
}
/* Reserve wait pin if it is required and valid */