diff options
| author |   Qinglang Miao <miaoqinglang@huawei.com> | 2020-11-20 15:48:46 +0800 |
|---|---|---|
| committer |   Ulf Hansson <ulf.hansson@linaro.org> | 2020-11-24 11:26:55 +0100 |
| commit | e3e9ced5c93803d5b2ea1942c4bf0192622531d6 (patch) | |
| tree | b67b364bbe0a1f7c5d4e37999073dce08eba5bda /drivers/memstick/core | |
| parent | mmc: sdhci-st: drop of_match_ptr from of_device_id table (diff) | |
| download | linux-dev-e3e9ced5c93803d5b2ea1942c4bf0192622531d6.tar.xz linux-dev-e3e9ced5c93803d5b2ea1942c4bf0192622531d6.zip | |
memstick: fix a double-free bug in memstick_check
kfree(host->card) has been called in put_device so that
another kfree would raise cause a double-free bug.
Fixes: 0193383a5833 ("memstick: core: fix device_register() error handling")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
Link: https://lore.kernel.org/r/20201120074846.31322-1-miaoqinglang@huawei.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Diffstat (limited to 'drivers/memstick/core')
| -rw-r--r-- | drivers/memstick/core/memstick.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/memstick/core/memstick.c b/drivers/memstick/core/memstick.c index ef03d6fafc5c..12bc3f5a6cbb 100644 --- a/drivers/memstick/core/memstick.c +++ b/drivers/memstick/core/memstick.c @@ -468,7 +468,6 @@ static void memstick_check(struct work_struct *work) host->card = card; if (device_register(&card->dev)) { put_device(&card->dev); - kfree(host->card); host->card = NULL; } } else |